Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress integration migrated to 11+ #172

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Cypress integration migrated to 11+ #172

merged 7 commits into from
Jan 11, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Dec 7, 2022 •
edited
Loading

Description of the Change

Cypress integration migrated to 11+

Closes #166

How to test the Change

  • Install NPM dependencies
  • Run npm run cypress:run to test without GUI
  • Run npm run cypress:open to test with GUI
  • Check if tests pass successfully

Changelog Entry

Changed - Cypress integration migrated to 11+

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul requested a review from dkotter December 7, 2022 09:28
@jayedul jayedul self-assigned this Dec 7, 2022
@faisal-alvi
Copy link
Member

@jayedul seems like the Cypress tests are failing in the pipeline, can you please check?

@faisal-alvi faisal-alvi added this to the Future Release milestone Dec 7, 2022
faisal-alvi
faisal-alvi requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayedul thanks for the work. Other than checking the GitHub action for cypress, I have left minor suggestions below, please have a look.

.gitignore Outdated Show resolved Hide resolved
tests/cypress/config.config.js Outdated Show resolved Hide resolved
tests/cypress/integration/admin.test.js Outdated Show resolved Hide resolved
@jayedul
Copy link
Contributor Author

jayedul commented Dec 8, 2022

@jayedul seems like the Cypress tests are failing in the pipeline, can you please check?

Now all tests pass perfectly.

@faisal-alvi
Copy link
Member

@jayedul can you please resolve the conflicts?

@jayedul jayedul marked this pull request as ready for review January 11, 2023 09:41
faisal-alvi
faisal-alvi approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayedul Thank you for your efforts. 🚀

@faisal-alvi faisal-alvi merged commit 965584c into develop Jan 11, 2023
@faisal-alvi faisal-alvi deleted the fix/166 branch January 11, 2023 15:58
@jeffpaul jeffpaul modified the milestones: Future Release, 2.7.2 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

@dkotter dkotter Awaiting requested review from dkotter dkotter is a code owner

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

Migrate to Cypress 11
3 participants
@jayedul @faisal-alvi @jeffpaul