bbPress - make sure the functions to process image uploads are all there #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @foliovision thanks for raising a PR. However, I'm wondering, exactly where are you trying to upload an image? can you please share steps to regenerate the issue? (screenshot/video would be great!) |
faisal-alvi
added
the
needs:feedback
|
Hello @faisal-alvi here's the screenshot of the bbPress profile editing page:
The URL is like https://site.com/forums/users/{user-name}/edit Thanks, |
github-actions
bot
removed
the
needs:feedback
6 tasks
|
Closing as covered in #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When user tries to submit the image on the bbPress profile editing page, it fails to process. Some functions are missing and user gets a white screen.
Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
bbPress user profile editing now saves properly when the image is selected for avatar.
Checklist:
Changelog Entry
Fixed - image upload on bbPress profile edit page
Credits
Props @foliovision