Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/116 Rest of the admin.js content migrated #120

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented May 6, 2022

Description of the Change

Somehow the admin.js file's content is not fully migrated in the simple-local-avatars.js file in #118. This PR moves the content completely. The missed portion is from the #96.

Verification Process

Build the project and make sure the "Choose Default Avatar" works in the Settings > Discussion.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

n/a as it this PR is a part of #118.

Credits

Props @faisal-alvi @peterwilsoncc

@petenelson
Copy link

I like props, but that wasn't me.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@faisal-alvi faisal-alvi merged commit c9e62c9 into develop May 9, 2022
@faisal-alvi faisal-alvi deleted the fix/116-2 branch May 9, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants