Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more PHP Unit Tests #101

Merged
merged 10 commits into from
Mar 21, 2022
Merged

Adding more PHP Unit Tests #101

merged 10 commits into from
Mar 21, 2022

Conversation

faisal-alvi
Copy link
Member

Description of the Change

This PR adds more unit tests to the plugin. It is noted there are a few functions that should be covered in PHP Unit Tests.

Verification Process

Please make sure that new and old unit tests do not fail in Github Actions.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - New PHP Unit Tests.

Credits

Props @

@faisal-alvi faisal-alvi added this to the Future Release milestone Mar 4, 2022
@faisal-alvi faisal-alvi self-assigned this Mar 4, 2022
@faisal-alvi faisal-alvi marked this pull request as ready for review March 21, 2022 03:41
@faisal-alvi faisal-alvi requested review from a team and iamdharmesh and removed request for a team March 21, 2022 03:41
iamdharmesh
iamdharmesh approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @faisal-alvi, LGTM.!
Tests are passing in GitHub Actions and Local as well.

@faisal-alvi faisal-alvi merged commit 933b11f into develop Mar 21, 2022
@faisal-alvi faisal-alvi deleted the add/unit-tests branch March 21, 2022 13:51
@jeffpaul jeffpaul modified the milestones: Future Release, 2.3.0 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@faisal-alvi faisal-alvi

Labels
None yet
Projects
Open Source Practice
Archived in project
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@faisal-alvi @iamdharmesh @jeffpaul