-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action summary added #141
Conversation
@jayedul I noticed you marked this ready and then reverted to draft. I can see the data being included (my last commit testing it deliberately breaks a few things) but I'm not sure if I should be seeing the screen shot you've provided in the description on the summary tab. |
Thank you @peterwilsoncc for this commit c4193f1 I was wondering why all the E2E tests were not running after adding GH summary commands. That's why I reverted to draft to check later. As I can see this commit resolved the issue, this PR is ready to review now. And I'll have to use this fix in some other PRs that has this same issue.
You should if you run the following commands in your local system sequentially after running E2E tests. It will generate However for Github actions, I guess nothing else to do apart from checking if the scripts passed successfully. Or maybe @faisal-alvi can suggest something as he has some similar PR merged like this one 10up/simple-local-avatars#174 |
f85b28e
to
550308b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks!
I pushed a minor change as noted inline.
I've tested an action run with broken tests, but have since force pushed the relevant commit out of the history to avoid noise.
@@ -53,3 +53,22 @@ jobs: | |||
run: npm run env:start | |||
- name: Test | |||
run: npm run cypress:run | |||
- name: Update summary | |||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed this in 550308b to ensure the summary is displayed for both test passes and failures.
Description of the Change
Mochawesome reporter added for Cypress test report
Closes #124
Changelog Entry
Credits
Props @jayedul
Checklist: