Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch word_delimeter based filter #2409

Merged

Conversation

pschoffer
Copy link
Contributor

@pschoffer pschoffer commented Oct 14, 2021

Description of the Change

word_delimiter_graph is recommended in ElasticSearch 7.x over word_delimiter filter currently used by ewp_word_delimiter.

This change switches the underlying filter to match the recommendation.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Run index --setup, verify the filter still splits correct on caseChange and non-alpha symbols.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Changed: The base filter for ewp_word_delimiter was changed from word_delimiter to word_delimiter_graph based on ElasticSearch recommendation.

@felipeelia felipeelia added this to the 3.6.4 milestone Oct 14, 2021
@jesse-greathouse
Copy link

Nice suggestion from @yolih

@felipeelia felipeelia merged commit 46ed19a into 10up:develop Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants