Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests on group comment to check if EP is used #2390

Merged
merged 39 commits into from
Oct 11, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Oct 5, 2021

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#2335

Changelog Entry

@felipeelia
Copy link
Member

@Rahmon I saw that you've changed the test for testCommentQueryOrderCommentContent() from the foreach testing $comment->elasticsearch to $comments_query->elasticsearch_success. We are keeping that behavior in some other tests, is there any specific reason why you changed it only in this one? I'm fine with one or the other, I'm really just curious to see if I missed something.

For testBasicCommentQuery it seems we still are missing a test for the last \WP_Comment_Query() call. Other than that, this PR looks good!

@felipeelia felipeelia assigned Rahmon and unassigned felipeelia Oct 7, 2021
@Rahmon Rahmon force-pushed the chore/check-tests-group-comment-issue-2335 branch from 7d16537 to 9ba13ad Compare October 10, 2021 20:58
@Rahmon
Copy link
Contributor Author

Rahmon commented Oct 11, 2021

@Rahmon I saw that you've changed the test for testCommentQueryOrderCommentContent() from the foreach testing $comment->elasticsearch to $comments_query->elasticsearch_success. We are keeping that behavior in some other tests, is there any specific reason why you changed it only in this one? I'm fine with one or the other, I'm really just curious to see if I missed something.

For testBasicCommentQuery it seems we still are missing a test for the last \WP_Comment_Query() call. Other than that, this PR looks good!

@felipeelia I've updated to follow the same behavior. Thanks.

@Rahmon Rahmon assigned felipeelia and unassigned Rahmon Oct 11, 2021
@felipeelia felipeelia merged commit 1afa7f3 into develop Oct 11, 2021
@felipeelia felipeelia deleted the chore/check-tests-group-comment-issue-2335 branch October 11, 2021 19:53
@jeffpaul jeffpaul linked an issue Oct 21, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if all tests are using Elasticsearch
2 participants