Fix/facets pagination #2229
Merged
Fix/facets pagination #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oscarssanchez I've updated the PR and added some tests. Can you please take a look at the tests and add new ones if you think it's necessary? |
…into fix/facets-pagination
|
It seems the tests are failing because the latest commit will add a slash before the |
Yes, @oscarssanchez . Feel free to adjust and maybe add new tests |
Rahmon
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #2201
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
1.- Go to an archive
2.- Facets should remove pagination on all scenarios
Checklist:
Applicable Issues
Changelog Entry