Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: The element input must not appear as a descendant of the a element. #1854

Closed
RetroGameTalk opened this issue Aug 1, 2020 · 2 comments · Fixed by #1886
Closed

Error: The element input must not appear as a descendant of the a element. #1854

RetroGameTalk opened this issue Aug 1, 2020 · 2 comments · Fixed by #1886
Assignees
Labels
Milestone

Comments

@RetroGameTalk
Copy link

RetroGameTalk commented Aug 1, 2020

Describe the bug

The facets links are not hmtl5 valid.
Steps to Reproduce

  1. Have facets
  2. validate page with https://validator.w3.org/
  3. Scroll down to 'Error: The element input must not appear as a descendant of the a element'
  4. See error
<a href="/movie/?filter_genre=comedy" rel="nofollow">
    <input type="checkbox">Comedy
</a>

Expected behavior

it should use valid html.

Screenshots

Environment information

  • Device:
  • OS:
  • Browser and version:
  • WordPress version:
  • Plugins and version:
  • Theme and version:
  • Site Health Info:

Additional context

@RetroGameTalk
Copy link
Author

Also another error with facets:

Error: Element a is missing required attribute href.

This happens when we have
<a rel="nofollow">
On terms that are disabled (no posts with that term). a lacks href.

@brandwaffle brandwaffle linked a pull request Sep 15, 2020 that will close this issue
6 tasks
@felipeelia felipeelia mentioned this issue Sep 15, 2020
6 tasks
@amesplant
Copy link
Contributor

Merge Request pulled and ready for a Back End Engineer to add the form action to properly submit the form when JavaScript is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants