Merge pull request #2666 from 10up/fix/wc-search-by-order-id

WC Orders: properly add ID to fields when searching for digits
10up · Mar 22, 2022 · 0c040f0 · 0c040f0
2 parents 93b2e70 + 2d0b6c2
commit 0c040f0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/includes/classes/Feature/WooCommerce/WooCommerce.php b/includes/classes/Feature/WooCommerce/WooCommerce.php
@@ -392,7 +392,7 @@ public function translate_args( $query ) {
 			// Search query
 			if ( 'shop_order' === $post_type ) {
 				$default_search_fields = array( 'post_title', 'post_content', 'post_excerpt' );
-				if ( is_int( $s ) ) {
+				if ( ctype_digit( $s ) ) {
 					$default_search_fields[] = 'ID';
 				}
 				$search_fields = $query->get( 'search_fields', $default_search_fields );

diff --git a/tests/php/features/TestWooCommerce.php b/tests/php/features/TestWooCommerce.php
@@ -172,7 +172,7 @@ public function testSearchShopOrderById() {
 		ElasticPress\Elasticsearch::factory()->refresh_indices();
 
 		$args = array(
-			's'         => $shop_order_id,
+			's'         => (string) $shop_order_id,
 			'post_type' => 'shop_order',
 		);
 
@@ -215,7 +215,7 @@ public function testSearchShopOrderByMetaFieldAndId() {
 		ElasticPress\Elasticsearch::factory()->refresh_indices();
 
 		$args = array(
-			's'         => $shop_order_id_1,
+			's'         => (string) $shop_order_id_1,
 			'post_type' => 'shop_order',
 		);