Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leveraging --port flag to change browsersync port #95

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

nicholasio
Copy link
Member

Description of the Change

Fixes #89 by allowing passing a --port flag to browser sync 10up-toolkit start|watch --port=3002

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fixed: Allows passing a --port flag to browser-sync 10up-toolkit start|watch --port=3002

@nicholasio nicholasio added this to the 10up-toolkit@1.0.11 milestone Aug 4, 2021
@nicholasio nicholasio changed the title Levearing --port flag to change browsersync port Leveraging --port flag to change browsersync port Aug 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@nicholasio nicholasio merged commit f5c2022 into develop Aug 5, 2021
@nicholasio nicholasio deleted the fix/change-browsersync-default-port branch August 5, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing browsersync default port
1 participant