Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex in asset/resources' #63

Merged
merged 6 commits into from
May 22, 2021
Merged

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented May 21, 2021

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fixed: Regex in asset/resources.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 2 1
Warnings 1 0
Ignored 0 N/A
  • Result: ❌ failure

  • Annotations: 3 total


[failure] prettier/prettier


[failure] import/no-unresolved


[warning] no-new

disallow new operators outside of assignments or comparisons


Report generated by eslint-plus-action

@nicholasio nicholasio added this to the 10up-toolkit@1.0.5 milestone May 21, 2021
@nicholasio nicholasio marked this pull request as ready for review May 21, 2021 19:15
@nicholasio nicholasio merged commit ad7c717 into develop May 22, 2021
@nicholasio nicholasio deleted the fix/webpack-asset-modules branch May 22, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant