Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint #51

Merged
merged 4 commits into from
May 11, 2021
Merged

Stylelint #51

merged 4 commits into from
May 11, 2021

Conversation

nicholasio
Copy link
Member

Description of the Change

Alternate Designs

Benefits

  • Manage all related tools in one place
  • NPM 7 compat

Possible Drawbacks

Verification Process

  • Used the test theme at projects to validate the stylelint works as the rules trigger on webpack compilation.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@nicholasio
Copy link
Member Author

@joesnellpdx Could you take a quick look at this?

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] jsdoc/require-param-type

Requires that each @param tag has a type value.


Report generated by eslint-plus-action

Copy link

@joesnellpdx joesnellpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this implementation - no time to test.

@nicholasio nicholasio merged commit 4018c80 into develop May 11, 2021
@nicholasio nicholasio deleted the feature/stylelint branch May 11, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants