Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding certain config files #355

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented Jan 8, 2024

Related Issue/RFC: #347

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: 39adb13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nicholasio
Copy link
Member Author

The snapshots changed bc of the removal of an unncessary mocked function I removed from the tests (that after this PR was causing issues)

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works great!

@nicholasio nicholasio merged commit 01ade56 into develop Jan 9, 2024
5 checks passed
@nicholasio nicholasio deleted the fix/config-overriding branch January 9, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants