Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default value of useBlockAssets to true #337

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

fabiankaegy
Copy link
Member

@fabiankaegy fabiankaegy commented Oct 23, 2023

Related Issue/RFC: #325

Description of the Change

Enable useBlockAssets by default

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

@fabiankaegy fabiankaegy self-assigned this Oct 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 979ccf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fabiankaegy fabiankaegy linked an issue Oct 23, 2023 that may be closed by this pull request
1 task
@nicholasio nicholasio marked this pull request as ready for review November 6, 2023 13:07
@nicholasio nicholasio merged commit 71460c9 into develop Nov 6, 2023
5 checks passed
@nicholasio nicholasio deleted the feature/make-use-block-assets-default branch November 6, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useBlockAssets on by default
2 participants