Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop injecting wp-polyfill and add example for using react (with wp-element on the front-end) #193

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented Apr 25, 2022

Description of the Change

Closes #

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed: Stop injecting wp-polyfill as script deps.

Credits

Props @

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@nicholasio nicholasio changed the title example for using react on the front-end stop injecting wp-polyfill and add example for using react (with wp-element on the front-end) Apr 26, 2022
@nicholasio nicholasio added this to the 10up-toolkit@4.0.0 milestone Apr 26, 2022
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me (y)

Is there also going to be any guidance on when to use react on the frontend? For the most part, we have not advocated for it much because of the overhead it creates.

I just want to make sure that with making it easier to use we also provide folks with the proper best practices when it should be used :)

@nicholasio
Copy link
Member Author

nicholasio commented Apr 26, 2022

Thanks @fabiankaegy, we can add more guidance on using react on the front-end in the best practices. I think usecases are going to be minimum. I'm thinking about very specific functionality that's JS-driven which would be easier to build in react.

@nicholasio nicholasio merged commit acb401a into develop Apr 26, 2022
@nicholasio nicholasio deleted the feature/optimize-react-front-end branch April 26, 2022 16:37
@nicholasio nicholasio mentioned this pull request Apr 26, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants