Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove browser-sync packages by default and add deprecation notice #159

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

nicholasio
Copy link
Member

@nicholasio nicholasio commented Feb 26, 2022

Description of the Change

This PR removes browser-sync packages, adds a deprecation notice and instructions to re-enable browser-sync.

image

The reason to remove browser-sync is to get rid of an high severe security vulnerability in engine.io

Closes #158

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Deprecated: browser-sync

Credits

Props @

@nicholasio nicholasio added this to the 10up-toolkit@2.2.0 milestone Feb 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@nicholasio nicholasio mentioned this pull request Feb 26, 2022
1 task
@nicholasio nicholasio merged commit 5780d52 into develop Feb 28, 2022
@nicholasio nicholasio deleted the feature/drop-browser-sync branch February 28, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove BrowserSync
1 participant