Skip to content
This repository has been archived by the owner on May 26, 2024. It is now read-only.

Fix regression: Only write register address with no value. #4

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

aentinger
Copy link
Member

Sorry @generationmake 🙇

I'm quite sure i messed up the library during cleanup, can you test the version in this branch if it still works?

Cheers, Alex

@aentinger aentinger added topic: firmware Code that runs on an embedded system. type: bug labels Feb 10, 2022
@aentinger aentinger self-assigned this Feb 10, 2022
@github-actions
Copy link

Memory usage change @ e48fb7c

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 💚 -8 - -8 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 💚 -8 - -8 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 💚 -8 - -8 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 💚 -8 - -8 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 💚 -8 - -8 -0.0 - -0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 💚 -16 - -16 -0.01 - -0.01 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +20 - +20 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/TSL2550-Basic
flash
% examples/TSL2550-Basic
RAM for global variables
%
arduino:mbed_edge:edge_control 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect -8 -0.0 0 0.0
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0
arduino:samd:mkr1000 -16 -0.01 0 0.0
arduino:samd:mkrfox1200 -8 -0.0 0 0.0
arduino:samd:mkrgsm1400 -16 -0.01 0 0.0
arduino:samd:mkrnb1500 -16 -0.01 0 0.0
arduino:samd:mkrvidor4000 -8 -0.0 0 0.0
arduino:samd:mkrwan1300 -8 -0.0 0 0.0
arduino:samd:mkrwan1310 -8 -0.0 0 0.0
arduino:samd:mkrwifi1010 -16 -0.01 0 0.0
arduino:samd:mkrzero -16 -0.01 0 0.0
esp32:esp32:esp32 20 0.0 0 0.0
Click for full report CSV
Board,examples/TSL2550-Basic<br>flash,%,examples/TSL2550-Basic<br>RAM for global variables,%
arduino:mbed_edge:edge_control,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,-8,-0.0,0,0.0
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0
arduino:samd:mkr1000,-16,-0.01,0,0.0
arduino:samd:mkrfox1200,-8,-0.0,0,0.0
arduino:samd:mkrgsm1400,-16,-0.01,0,0.0
arduino:samd:mkrnb1500,-16,-0.01,0,0.0
arduino:samd:mkrvidor4000,-8,-0.0,0,0.0
arduino:samd:mkrwan1300,-8,-0.0,0,0.0
arduino:samd:mkrwan1310,-8,-0.0,0,0.0
arduino:samd:mkrwifi1010,-16,-0.01,0,0.0
arduino:samd:mkrzero,-16,-0.01,0,0.0
esp32:esp32:esp32,20,0.0,0,0.0

@generationmake
Copy link
Contributor

Hi @aentinger
I tested it with my sensor and it works like expected.
so please merge.

Copy link
Contributor

@generationmake generationmake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test with device was ok.

@aentinger
Copy link
Member Author

Thank you @generationmake 🙇

@aentinger aentinger merged commit 5f2d18e into main Feb 14, 2022
@aentinger aentinger deleted the fix-regression branch February 14, 2022 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: firmware Code that runs on an embedded system. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants