[BUGFIX] Corrige le crash en cas d'erreurs lors de la récupération des metrics #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois2metz
force-pushed
the
fix-crash
branch
from
f7409df to
d471f66
Compare
octo-topi
approved these changes
Nov 14, 2022
francois2metz
added
Tech review OK
🚀 Ready to Merge
and removed
Tech review needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Si une méthode d'API lors de la récupération des metriques renvoit une erreur, l'exception n'est pas récupéré car le bloc de code n'est pas attendu via un await.
🤖 Solution
Ajouter un Promise.all et rajouter un await.
💯 Pour tester
FT_METRICS=yes