Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formater automatiquement le code #19

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Conversation

octo-topi
Copy link
Contributor

@octo-topi octo-topi commented Sep 15, 2022

🦄 Problème

Les éditeurs de code indentent différemment les fichiers, ce qui introduit du bruit dans les diffs des PRs.

🤖 Solution

Utiliser eslint + prettier et l'intégrer dans la CI.

🌈 Remarques

Suppression de la section engine en l'absence de .nvmrc (corrigé dans #18 )

💯 Pour tester

Modifier l'indentation d'un fichier existant.
Commiter et push, vérifier que la CI sort en erreur.

@octo-topi octo-topi added Tech review needed team-captains This your captain speaking labels Sep 15, 2022
@octo-topi octo-topi self-assigned this Sep 15, 2022
Copy link
Contributor

@yoandl yoandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants