Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #60

Merged
merged 16 commits into from
Oct 31, 2024
Merged

Minor improvements #60

merged 16 commits into from
Oct 31, 2024

Conversation

klaidliadon
Copy link
Contributor

@klaidliadon klaidliadon commented Oct 30, 2024 •
edited
Loading

  • Update to latest authcontrol (v.0.0.7)
  • The argument middleware.Options is not a pointer anymore
  • Added Options.ApplyDefaults method
  • Switched from logger to slog

david-littlefarmer
david-littlefarmer reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, please revert the logging changes.

cache.go Outdated Show resolved Hide resolved
cache.go Outdated Show resolved Hide resolved
handler_test.go Outdated Show resolved Hide resolved
proto/proto.go Outdated Show resolved Hide resolved
pkieltyka
pkieltyka requested changes Oct 30, 2024
View reviewed changes
cache.go Outdated Show resolved Hide resolved
middleware/middleware_ratelimit.go Show resolved Hide resolved
@pkieltyka pkieltyka merged commit 22a7777 into master Oct 31, 2024
1 check passed
@pkieltyka pkieltyka deleted the minor-improvements branch October 31, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkieltyka pkieltyka pkieltyka requested changes

@VojtechVitek VojtechVitek Awaiting requested review from VojtechVitek

@david-littlefarmer david-littlefarmer Awaiting requested review from david-littlefarmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klaidliadon @pkieltyka @david-littlefarmer