Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point fixed on tremolo and parenthesis #1540

Merged
merged 2 commits into from
Apr 5, 2023
Merged

point fixed on tremolo and parenthesis #1540

merged 2 commits into from
Apr 5, 2023

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Mar 19, 2023

No visual differences on Paranthesis. Tremolos are now bigger.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Mar 19, 2023

pptr-Percussion Percussion_Snare2 Bravura svg_current
pptr-Percussion Percussion_Snare2 Bravura svg_reference

@rvilarl
Copy link
Collaborator Author

rvilarl commented Mar 19, 2023

Captured from Musescore, I would say that size is right but position is and was too close to notehead. Musescore extends the stem if required. We do not.

image

@rvilarl rvilarl mentioned this pull request Mar 29, 2023
@rvilarl
Copy link
Collaborator Author

rvilarl commented Apr 2, 2023

@AaronDavidNewman @mscuthbert @ronyeh @sschmidTU I would like to get your oppinion on this one. I go next week on holidays and it would be great to have the new beta ready. I think that the new size is better and closer to the one present on other rendering tools. I also believe that we introduced the big variant (feature request) because the originals wer too small.

@rvilarl rvilarl added the 4.2 label Apr 3, 2023
@ronyeh
Copy link
Collaborator

ronyeh commented Apr 5, 2023

Seeing the MuseScore output, it is clear that our solution should adjust the length of the stem to improve the spacing. Otherwise the bigger tremolo makes it look too crowded, since it is right next to the notehead.

@ronyeh
Copy link
Collaborator

ronyeh commented Apr 5, 2023

There is a

const start = note.getModifierStartXY(this.position, this.index);
let x = start.x;

Is there something we can do if we use the start.y? Maybe we should adjust it to be farther away from the note head, so we can accommodate the heavier tremolo strokes.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Apr 5, 2023

I have uncreased the distance to the notehead, @ronyeh thaks for the feedback

pptr-Percussion Percussion_Snare2 Bravura svg_current

Increasing the stem lenght should be another PR, merging

@rvilarl rvilarl merged commit adf7520 into 0xfe:master Apr 5, 2023
@rvilarl rvilarl deleted the point/tremoloParenthesis branch May 7, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants