-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated installation script. #6
Conversation
Refactored and reworked the script to increase efficiency. I've added some checks that decrease the workload of the script when running an update or if it fails during an installation due to whatever reason. Added specific region downloading, unsure if this is any use but when checking the various version of the game I did notice some were labelled differently from others so depending on Region, it's probably best to download the correct one. No longer requires Unity Hub to be installed. Instead it directly downloads the necessary unity files, moves across the ones required and dumps the rest to save space and installation time. Reworked how updating works, just because a full rm -rf isn't necessary and instead the game works fine after updating without deleting every file, deeming it unnecessary to delete /Bin folder.
Hi, thanks for your improvements! I just tested the script to update my outdated installation and noticed by keeping the We could remove |
Tested and now seems to work when updating from a previous version. Also seems to work fine when installing fresh.
Fixes the issues brought up about duplicate files and previous installations. Now it minimises the installation / updating process.
Cool, with a little tinkering here and there, I think it's finally at a stable place. I've tested both a fresh install and tested updating and both seem to work fine. Feel free to give the new revision a spin. |
Thanks again, I think it's a nice improvement! I've only added some small adjustments. The script is well optimized now, I think further improvements would require optimizing the ngdp download itself, e.g. in terms of storage consumption. |
so, it's no longer possible to copy over an existing macOS hearthstone install? seems like a regression that could have been avoided, there was no need to remove that functionality, seems to me edit: same goes for unity installation... why not keep that functionality of passing in the unity install dir, there was no need to remove that |
Hey, sorry, I have not verified that this method remains functional and I've not expected it's still used. |
I couldn't get that to work at least (provide macOS install dir as first argument), kept giving me "Not found" or something, I'll recheck later |
Add compatibility for custom installation directory and unity files
I've updated the script and it should now work again :) |
confirming it works again :-) thanks |
Refactored and reworked the script to increase efficiency.
I've added some checks that decrease the workload of the script when running an update or if it fails during an installation due to whatever reason.
Added specific region downloading, unsure if this is any use but when checking the various versions of the game I did notice some were labelled differently from others so depending on Region, it's probably best to download the correct one.
No longer requires Unity Hub to be installed. Instead it directly downloads the necessary unity files, moves across the ones required and dumps the rest to save space and installation time.
Reworked how updating works, just because a full rm -rf isn't necessary and instead the game works fine after updating without deleting every file, deeming it unnecessary to delete /Bin folder.