This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add Uniswap V2 support to @0x/asset-swapper #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
requested review from
abandeali1,
BMillman19,
dave4506 and
fragosti
as code owners
xianny
requested review from
dorothy-zbornak and
dekz
and removed request for
BMillman19,
fragosti,
dave4506 and
abandeali1
dekz
reviewed
Jun 9, 2020
packages/asset-swapper/src/utils/market_operation_utils/orders.ts
Outdated
Show resolved
Hide resolved
packages/asset-swapper/src/utils/market_operation_utils/types.ts
Outdated
Show resolved
Hide resolved
xianny
force-pushed
the
feat/AS-uniswap-v2
branch
from
961a336 to
68fd915
Compare
xianny
commented
Jun 9, 2020
dorothy-zbornak
suggested changes
Jun 9, 2020
packages/asset-swapper/src/utils/market_operation_utils/sampler_operations.ts
Show resolved
Hide resolved
dekz
approved these changes
Jun 11, 2020
| @@ -20,6 +20,7 @@ | |||
| "devUtils": "0x74134cf88b21383713e096a5ecf59e297dc7f547", | |||
| "erc20BridgeProxy": "0x8ed95d1746bf1e4dab58d8ed4724f1ef95b20db0", | |||
| "uniswapBridge": "0x36691c4f426eb8f42f150ebde43069a31cb080ad", | |||
| "uniswapV2Bridge": "0x0000000000000000000000000000000000000000", | |||
There was a problem hiding this comment.
Suggested change
| "uniswapV2Bridge": "0x0000000000000000000000000000000000000000", | |
| "uniswapV2Bridge": "0xdcd6011f4c6b80e470d9487f5871a0cba7c93f48", |
Deployed https://etherscan.io/address/0xdcd6011f4c6b80e470d9487f5871a0cba7c93f48#code
packages/migrations/CHANGELOG.json
Outdated
| @@ -9,6 +9,10 @@ | |||
| { | |||
| "note": "Add `ERC20BridgeSampler` deployment", | |||
| "pr": 2541 | |||
| }, | |||
| { | |||
| "note": "Added `UniswapV2Bridge` address (null)", | |||
There was a problem hiding this comment.
Suggested change
| "note": "Added `UniswapV2Bridge` address (null)", | |
| "note": "Added `UniswapV2Bridge` address on mainnet", |
| @@ -20,6 +20,7 @@ | |||
| "devUtils": "0x74134cf88b21383713e096a5ecf59e297dc7f547", | |||
| "erc20BridgeProxy": "0x8ed95d1746bf1e4dab58d8ed4724f1ef95b20db0", | |||
| "uniswapBridge": "0x36691c4f426eb8f42f150ebde43069a31cb080ad", | |||
| "uniswapV2Bridge": "0x0000000000000000000000000000000000000000", | |||
| "erc20BridgeSampler": "0xc0154b14cc60a6661171fdc817f759429a57e184", | |||
There was a problem hiding this comment.
Suggested change
| "erc20BridgeSampler": "0xc0154b14cc60a6661171fdc817f759429a57e184", | |
| "erc20BridgeSampler": "0xdfec429f7d87bd9911211bbb3b8b83df0f37ebc7", |
As at 1b5746b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Uniswap V2 to asset-swapper.
Testing instructions
Instead of writing new tests, I replaced Uniswap (V1) with V2 in existing tests.
Types of changes
Checklist:
[WIP]if necessary.