Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Add Uniswap V2 to ERC20BridgeSampler #2595

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Add Uniswap V2 to ERC20BridgeSampler #2595

merged 4 commits into from
Jun 4, 2020

Conversation

dorothy-zbornak
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak commented Jun 3, 2020 •
edited by xianny
Loading

Description

Adds UniswapV2 to ERC20BridgeSampler.

Testing instructions

Review Uniswap docs to make sure we've mocked the UniswapV2Router01 contract correctly.

Review unit tests implementation.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dorothy-zbornak dorothy-zbornak force-pushed the feat/erc20-bridge-sampler/uniswapv2-tests branch from debe40d to 4066c17 Compare June 3, 2020 18:01
@xianny xianny marked this pull request as ready for review June 3, 2020 19:11
@xianny xianny requested review from abandeali1 and hysz as code owners June 3, 2020 19:11
@xianny xianny requested a review from dekz June 3, 2020 19:12
@xianny xianny removed request for hysz and abandeali1 June 3, 2020 19:16
dekz
dekz approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@dekz dekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much cleaner than v1

@dorothy-zbornak dorothy-zbornak merged commit 32793cc into development Jun 4, 2020
@dorothy-zbornak dorothy-zbornak deleted the feat/erc20-bridge-sampler/uniswapv2-tests branch June 4, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xianny xianny xianny approved these changes

@dekz dekz dekz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dorothy-zbornak @dekz @xianny @merklejerk