Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

instanceof Array -> Array.isArray #2567

Merged
merged 1 commit into from
Apr 28, 2020
Merged

instanceof Array -> Array.isArray #2567

merged 1 commit into from
Apr 28, 2020

Conversation

moodlezoup
Copy link
Contributor

Description

fixes #2558

gotta love js
http://web.mit.edu/jwalden/www/isArray.html

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@moodlezoup moodlezoup requested a review from hysz as a code owner April 28, 2020 01:10
hysz
hysz approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Let's merge (~‾▿‾)~

@moodlezoup moodlezoup force-pushed the fix/instanceof-array-isArray branch from b754684 to 351ea8b Compare April 28, 2020 01:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 79.588% when pulling 351ea8b on fix/instanceof-array-isArray into b34edcb on development.

@moodlezoup moodlezoup merged commit a90b463 into development Apr 28, 2020
@moodlezoup moodlezoup deleted the fix/instanceof-array-isArray branch April 28, 2020 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hysz hysz hysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@0x/contract-wrappers: marketBuyOrdersFillOrKill incorrect ABI encoding
3 participants
@moodlezoup @coveralls @hysz