This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Disable Geth tests in CircleCI #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
approved these changes
Apr 3, 2019
abandeali1
approved these changes
Apr 4, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Geth tests are currently failing because our fork has become out of date. I'm working on addressing the issue (not easy because some of the features we need are broken in the latest
masterversion of Geth). See ethereum/go-ethereum#19346 for some additional background.In the meantime, it's better to just disable the tests so everyone's CI will be all green and any other failures will be more obvious.
Checklist:
[WIP]if necessary.