@0x/asset-swapper: Address review feedback

0xProject · Jun 8, 2020 · 1a1a777 · 1a1a777
1 parent d0714d8
commit 1a1a777
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/packages/asset-swapper/src/quote_consumers/exchange_proxy_swap_quote_consumer.ts b/packages/asset-swapper/src/quote_consumers/exchange_proxy_swap_quote_consumer.ts
@@ -125,9 +125,14 @@ export class ExchangeProxySwapQuoteConsumer implements SwapQuoteConsumerBase {
             )
             .getABIEncodedTransactionData();
 
+        let ethAmount = quote.worstCaseQuoteInfo.protocolFeeInWeiAmount;
+        if (exchangeProxyOpts.isFromETH) {
+            ethAmount = ethAmount.plus(quote.worstCaseQuoteInfo.takerAssetAmount);
+        }
+
         return {
             calldataHexString,
-            ethAmount: quote.worstCaseQuoteInfo.protocolFeeInWeiAmount,
+            ethAmount,
             toAddress: this._transformFeature.address,
             allowanceTarget: this.contractAddresses.exchangeProxyAllowanceTarget,
         };

diff --git a/packages/contract-wrappers/CHANGELOG.json b/packages/contract-wrappers/CHANGELOG.json
@@ -32,7 +32,7 @@
             },
             {
                 "note": "Add `ITransformERC20`",
-                "pr": "TODO"
+                "pr": 2591
             }
         ]
     },

diff --git a/packages/migrations/CHANGELOG.json b/packages/migrations/CHANGELOG.json
@@ -11,7 +11,7 @@
                 "pr": 2541
             },
             {
-                "note": "Return emtpy Exchange Proxy addresses",
+                "note": "Return empty Exchange Proxy addresses",
                 "pr": 2591
             }
         ]
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,7 +32,7 @@ @@
                 },
                 {
                     "note": "Add `ITransformERC20`",
-                    "pr": "TODO"
+                    "pr": 2591
                 }
             ]
         },
@@ Expand Down @@