This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Simplify unexpiration logic in convertValidationResultsIntoOrderEvents#856

Merged

z2trillion merged 17 commits intodevelopmentfrom mason/reorg

Jul 14, 2020

+35-81

Commits on Jul 8, 2020

Name and use isOrderUnexpired
Mason Liang
committed
Use newFillableAmount
Mason Liang
committed
Replace nil with newFillableAmount
Mason Liang
committed
Consolidate checks for rewatchOrder
Mason Liang
committed
Remove checks that are always true
Mason Liang
committed
Move database updates into unexpiration check
Mason Liang
committed
Rename to timeStampIsValid and remove unneeded check
Mason Liang
committed
typos
Mason Liang
committed
time stamp -> timestamp and correct comment
Mason Liang
committed

Commits on Jul 9, 2020

Clarify comment

z2trillion
and
albrow
authored
fix typo

z2trillion
and
albrow
authored
Remove unused private function
Mason Liang
committed
Remove nil check for non-nil argument
Mason Liang
committed

Commits on Jul 10, 2020

Rename function
Mason Liang
committed

Commits on Jul 14, 2020

Re-add comments
Mason Liang
committed
Rename to expirationTimeIsValid
Mason Liang
committed
Expand comment

z2trillion
and
albrow
authored