Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(field): Re-enable alloc for tests #1601

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix(field): Re-enable alloc for tests #1601

merged 1 commit into from
Jun 13, 2024

Conversation

Nashtare
Copy link
Collaborator

For some reason, this was disabling all unit tests in the plonky2_field crate.
Credits to @gio256 for noticing!

@Nashtare Nashtare added the bug Something isn't working label Jun 12, 2024
wborgeaud
wborgeaud approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashtare Nashtare merged commit ed6f452 into main Jun 13, 2024
4 checks passed
@Nashtare Nashtare deleted the ci_field branch June 13, 2024 10:29
@gio256 gio256 mentioned this pull request Jun 13, 2024
Merged
hratoanina pushed a commit that referenced this pull request Jul 16, 2024
@Nashtare @hratoanina
fix(field): reenable alloc for tests (#1601)
3ca0d73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborgeaud wborgeaud wborgeaud approved these changes

@muursh muursh muursh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Zero EVM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nashtare @muursh @wborgeaud