Fix CTLs with exactly two looking tables #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nashtare
changed the title
muursh
approved these changes
Mar 14, 2024
LindaGuiga
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
The fix looks good to me, thanks! But I think we shouldn't need helper columns for 2 columns (and that's why it was ignored). The constraints with two looking columns would still be of degree 3 without helper columns: combin0 * combin1 * z - filter0 * combin1 - filter1 * combin0. SO I think we could try to take that into account in another PR to save an extra column in that case!
|
Yeah I noticed it while fixing, but would probably be requiring more refactor and I wanted a quick fix :') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way helper columns were computed was truncating the resulting vector for
n = 2, resulting in quotient polynomial check failure.closes #1554