Pacify clippy with latest nightly toolchain
#1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nashtare
commented
Feb 28, 2024
| @@ -923,7 +923,7 @@ impl<F: RichField> AlgebraicHasher<F> for PoseidonHash { | |||
| pub(crate) mod test_helpers { | |||
| use super::*; | |||
|
|
|||
| pub(crate) fn check_test_vectors<F: Field>( | |||
There was a problem hiding this comment.
Poseidon is a super trait of Field
| @@ -222,7 +222,7 @@ pub trait Witness<F: Field>: WitnessWrite<F> { | |||
| } | |||
| } | |||
|
|
|||
| fn get_merkle_cap_target<H: Hasher<F>>(&self, cap_target: MerkleCapTarget) -> MerkleCap<F, H> | |||
There was a problem hiding this comment.
AlgebraicHasher is a supertrait of Hasher
muursh
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy complaining about multiple bound locations and such