Skip to content

Commit

Permalink
fix: make from_noncanonical_biguint work for zero (#1427)
Browse files Browse the repository at this point in the history
  • Loading branch information
shuklaayush authored Dec 15, 2023
1 parent 71dff6e commit fdd7ee4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions field/src/goldilocks_field.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use core::hash::{Hash, Hasher};
use core::iter::{Product, Sum};
use core::ops::{Add, AddAssign, Div, DivAssign, Mul, MulAssign, Neg, Sub, SubAssign};

use num::{BigUint, Integer};
use num::{BigUint, Integer, ToPrimitive};
use plonky2_util::{assume, branch_hint};
use serde::{Deserialize, Serialize};

Expand Down Expand Up @@ -147,7 +147,7 @@ impl Field for GoldilocksField {
}

fn from_noncanonical_biguint(n: BigUint) -> Self {
Self(n.mod_floor(&Self::order()).to_u64_digits()[0])
Self(n.mod_floor(&Self::order()).to_u64().unwrap())
}

#[inline(always)]
Expand Down

0 comments on commit fdd7ee4

Please sign in to comment.