feat: Extend AdviceProvider trait
#987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
force-pushed
the
frisitano-tx-result
branch
3 times, most recently
from
2317779
to
5176881
Compare
bobbinth
approved these changes
Jul 4, 2023
core/Cargo.toml
Outdated
| @@ -21,7 +21,7 @@ std = ["math/std", "winter-utils/std"] | |||
|
|
|||
| [dependencies] | |||
| math = { package = "winter-math", version = "0.6", default-features = false } | |||
| crypto = { package = "miden-crypto", version = "0.6", default-features = false } | |||
| crypto = { package = "miden-crypto", git = "https://github.com/0xPolygonMiden/crypto.git", branch = "frisitano-tx-result", default-features = false } | |||
There was a problem hiding this comment.
I might have missed it - but seems like the changes in this PR should work fine with v0.6. If so, let's revert back here.
There was a problem hiding this comment.
That's correct however I needed to have consistent versions of crypto for my work in miden-base. It's not a blocker for this PR. I will revert v0.6, merge and then restore the branch and continue using it for downstream (miden-base) dev.
processor/src/advice/providers.rs
Outdated
| // TODO: Do we want to return a generic MerkleStore instead of a SimpleMerkleMap? | ||
| fn get_store_subset<I, R>(&self, roots: I) -> MerkleStore |
There was a problem hiding this comment.
I haven't thought about it much. Seems like returning MerkleStore (the way it is now) is a bit clearer - but I don't really have a strong preference.
There was a problem hiding this comment.
Lets leave it as is as theres no obvious reason to make it generic at this point.
frisitano
force-pushed
the
frisitano-tx-result
branch
from
5176881
to
764e8be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
get_mapped_values(..)andget_store_subset(..)methods on theAdviceProvidertrait and implements the methods forBaseAdviceProvider,MemAdviceProviderandRecAdviceProvider.