Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced tuple with struct for readability #878

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Replaced tuple with struct for readability #878

merged 1 commit into from
Apr 25, 2023

Conversation

hackaugusto
Copy link
Contributor

Describe your changes

It is a bit better to have a struct with named fields instead of a tuple with unnamed ones for readability.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

bobbinth
bobbinth approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@hackaugusto hackaugusto merged commit b134c92 into next Apr 25, 2023
@hackaugusto hackaugusto deleted the hacka-tests-replaced-tuple-with-struct-for-readability branch April 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@vlopes11 vlopes11 Awaiting requested review from vlopes11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackaugusto @bobbinth