ExpImm and ExpBitLength assembly serialization fix #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The ExpImm and ExpBitLength instruction were not using their respective opcode during serialisation and was causing a few tests to fail. This has been rectfied in this PR and correct opcode have been assigned to both of them. Signed-off-by: 0xKanekiken <100861945+0xKanekiKen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduce a fix for #553.
The ExpImm and ExpBitLength instructions were not using their respective opcode during serialization, causing a few tests in #553 to fail. This PR rectifies this issue, and the correct opcode is assigned to both.
Checklist before requesting a review
nextaccording to naming convention.