Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eq and neq parsers, u32 error message #528

Merged
merged 1 commit into from
Nov 19, 2022
Merged

eq and neq parsers, u32 error message #528

merged 1 commit into from
Nov 19, 2022

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Nov 19, 2022 •
edited
Loading

Fixed parse_u32checked_eq() and parse_u32checked_neq() parsers ― now checked_eq and checked_neq operations could be used with immediate values.
Error messages in u32checked_div_b_fail(), u32checked_mod_b_fail() and u32checked_divmod_b_fail() integration tests was updated with new AssemblerError messages.

@Fumuran Fumuran mentioned this pull request Nov 19, 2022
Merged
bobbinth
bobbinth approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for catching these.

@bobbinth bobbinth merged commit 5dc8dd8 into 0xPolygonMiden:instruction-parsers Nov 19, 2022
@Fumuran Fumuran deleted the parsers-fix branch November 29, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fumuran @bobbinth