Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PIPE operation and related assembly instruction #491

Merged
merged 7 commits into from
Nov 14, 2022
Merged

Add PIPE operation and related assembly instruction #491

merged 7 commits into from
Nov 14, 2022

Conversation

grjte
Copy link
Contributor

@grjte grjte commented Nov 10, 2022

Implements the pipe operation and adv_pipe assembly instruction as described in #336

@grjte grjte changed the base branch from main to next November 10, 2022 15:02
@grjte grjte marked this pull request as ready for review November 11, 2022 15:32
@grjte grjte requested a review from bobbinth November 11, 2022 15:32
bobbinth
bobbinth requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a few small comments inline.

processor/src/errors.rs Show resolved Hide resolved
processor/src/advice/mod.rs Outdated Show resolved Hide resolved
processor/src/advice/mod.rs Outdated Show resolved Hide resolved
assembly/src/parsers/io_ops/adv_ops.rs Show resolved Hide resolved
@grjte grjte requested a review from bobbinth November 14, 2022 12:43
bobbinth
bobbinth approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@bobbinth bobbinth merged commit d414350 into 0xPolygonMiden:next Nov 14, 2022
@bobbinth bobbinth mentioned this pull request Nov 14, 2022
Merged
26 tasks
@grjte grjte mentioned this pull request Nov 15, 2022
Merged
@grjte grjte deleted the feat-op-pipe branch November 16, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grjte @bobbinth