Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kernel ROM #443

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Implement Kernel ROM #443

merged 3 commits into from
Nov 1, 2022

Conversation

bobbinth
Copy link
Contributor

@bobbinth bobbinth commented Oct 24, 2022

This PR implements Kernel ROM chiplet within the processor crate. This includes:

  • Implementing Kernel ROM chiplet.
  • Updating the Decoder to rely on Kernel ROM chiplet to check syscall validity.

Things left for future PRs:

  • Updating mdBook docs to describe the new structure of chiplets.
  • Implementing additional syscall semantics:
    • Setting fmp to $2^{31}$ when for inside syscalls.
    • Adding trace columns to enable checks preventing syscalls from within kernel context.
  • Update aux trace column needed for enforcing correctness of kernel ROM (this includes updates to chiplet bus).
    • Setting boundary constraints for the kernel against which a program was executed.

@bobbinth bobbinth force-pushed the kernel-rom branch 2 times, most recently from c3c5114 to 5ca3b0f Compare October 25, 2022 08:54
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two preliminary comments

processor/src/chiplets/kernel_rom/mod.rs Outdated Show resolved Hide resolved
processor/src/chiplets/kernel_rom/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few things inline, but I'll approve anyway, as they're all comment-related or minor nits

processor/src/chiplets/mod.rs Outdated Show resolved Hide resolved
processor/src/chiplets/mod.rs Outdated Show resolved Hide resolved
processor/src/chiplets/kernel_rom/mod.rs Outdated Show resolved Hide resolved
processor/src/chiplets/tests.rs Outdated Show resolved Hide resolved
processor/src/chiplets/tests.rs Outdated Show resolved Hide resolved
processor/src/chiplets/tests.rs Outdated Show resolved Hide resolved
processor/src/chiplets/tests.rs Show resolved Hide resolved
processor/src/chiplets/kernel_rom/mod.rs Outdated Show resolved Hide resolved
processor/src/chiplets/kernel_rom/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants