Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update metal codebase to adjust it to 0.9 version of crates #1357

Merged
merged 8 commits into from
Jun 20, 2024
Merged

fix: update metal codebase to adjust it to 0.9 version of crates #1357

merged 8 commits into from
Jun 20, 2024

Conversation

TheMenko
Copy link
Contributor

@TheMenko TheMenko commented Jun 18, 2024 •
edited
Loading

Describe your changes

Before this can be merged, it is required for miden-gpu PR to be merged as well.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@bobbinth bobbinth mentioned this pull request Jun 18, 2024
Merged
bobbinth
bobbinth requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left one comment inline.

Also, we need to update miden-gpu dependency to v0.2.0.

prover/src/gpu/metal/mod.rs Outdated Show resolved Hide resolved
@bobbinth
Copy link
Contributor

oh - and could you also update the changelog?

@TheMenko TheMenko force-pushed the fix-update-metal-prover-codebase branch from b3fa29c to c334bad Compare June 20, 2024 17:18
bobbinth
bobbinth approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 0c19d50 into 0xPolygonMiden:next Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMenko @bobbinth