Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling debug mode via ExecutionOptions #1316

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

bobbinth
Copy link
Contributor

@bobbinth bobbinth commented Apr 25, 2024

This PR allows enabling of debug mode via ExecutionOptions. This, in turn, allows us to execute programs in debug mode via processor::execute() function - something that is needed to enable more streamlined debugging for users.

This PR is made against the main branch because this is a non-breaking change that we would like to release sooner rather than later as we want to propagate it to the transaction executor in miden-base.

Copy link
Contributor

@Dominik1999 Dominik1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

Is with_debugging() actually way slower? If so, should we mention it?

@bobbinth
Copy link
Contributor Author

Is with_debugging() actually way slower? If so, should we mention it?

It would be slower, but not sure by how much. It would also consume more memory, but again, not sure if that would be too noticeable.

@bobbinth bobbinth merged commit a0da333 into main Apr 25, 2024
15 checks passed
@bobbinth bobbinth deleted the bobbin-exec-options-debug branch April 25, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants