Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogUp-based Virtual Bus #1307

Merged
merged 38 commits into from
Jun 25, 2024
Merged

LogUp-based Virtual Bus #1307

merged 38 commits into from
Jun 25, 2024

Commits on Mar 22, 2024

  1. chore: fix no-std errors

    @Al-Kindi-0
    Al-Kindi-0 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    44a031e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. merge next

    @Al-Kindi-0
    Al-Kindi-0 committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fa5bd2e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'next' of https://github.com/0xPolygonMiden/miden-vm int… 

    …o next
    @Al-Kindi-0
    Al-Kindi-0 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    48116ad View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge branch 'next' of https://github.com/0xPolygonMiden/miden-vm int… 

    …o next
    @Al-Kindi-0
    Al-Kindi-0 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b2b2de5 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'next' of https://github.com/0xPolygonMiden/miden-vm int… 

    …o next
    @Al-Kindi-0
    Al-Kindi-0 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e2ce938 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'next' of https://github.com/0xPolygonMiden/miden-vm int… 

    …o next
    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0bbb515 View commit details
    Browse the repository at this point in the history

  2. feat: migrate to new Winterfell release

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7078870 View commit details
    Browse the repository at this point in the history

  3. chore: fix no-std errors 

    refactor: serialize usize with write_usize (#1266)
    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    df9b110 View commit details
    Browse the repository at this point in the history

  4. feat: sum-check protocol

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    699cb11 View commit details
    Browse the repository at this point in the history

  5. fix: no-std

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3b2acf5 View commit details
    Browse the repository at this point in the history

  6. chore: fmt

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    431b937 View commit details
    Browse the repository at this point in the history

  7. fix: remove challenger marker

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2686d65 View commit details
    Browse the repository at this point in the history

  8. chore: add evaluation point to final eval claim output of prover

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    de541c5 View commit details
    Browse the repository at this point in the history

  9. chore: fix typos and comments

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5110915 View commit details
    Browse the repository at this point in the history

  10. chore: nits and renaming

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7537be3 View commit details
    Browse the repository at this point in the history

  11. refactor: remove Option for FinalOpeningClaim

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    87e3c49 View commit details
    Browse the repository at this point in the history

  12. chore: namings comments and misc.

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    720ac33 View commit details
    Browse the repository at this point in the history

  13. wip: move to coefficient form

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cea681a View commit details
    Browse the repository at this point in the history

  14. feat: move sum-check round polys to coefficient form representation

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0fed9cd View commit details
    Browse the repository at this point in the history

  15. fix: add file

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cb503d1 View commit details
    Browse the repository at this point in the history

  16. wip: GKR protocol for virtual bus

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5b734d1 View commit details
    Browse the repository at this point in the history

  17. chore: add accessors and re-org

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    fa97e9e View commit details
    Browse the repository at this point in the history

  18. chore: fix merge conflicts

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    63243a8 View commit details
    Browse the repository at this point in the history

  19. chore: re-shuffle

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a275df4 View commit details
    Browse the repository at this point in the history

  20. chore: add vb errors and failing test

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d6cd197 View commit details
    Browse the repository at this point in the history

  21. fix: update trait def after rebase

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    016bc95 View commit details
    Browse the repository at this point in the history

  22. fix: use last_mut

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f46ac0c View commit details
    Browse the repository at this point in the history

  23. fix: address some comments

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    31609c5 View commit details
    Browse the repository at this point in the history

  24. Change suggestions to GKR implementation (#1323) 

    * change prover

* change verifier

* cleanup

* Remove `VirtualBusVerifier`

* Remove `VirtualBusProver`

* reorganize exports

* `LayerGatesInputs`

* use constant

* docstrings

* add TODO

* remove TODO

* clippy

* add static_assertions

* add padding comment

* add back `claim` in verifier
    @plafer @Al-Kindi-0
    plafer authored and Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7567a10 View commit details
    Browse the repository at this point in the history

  25. chore: rebase

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    37af90b View commit details
    Browse the repository at this point in the history

  26. chore: pacify warning

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    456ebec View commit details
    Browse the repository at this point in the history

  27. chore: change sumcheck_round signature

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    173e26a View commit details
    Browse the repository at this point in the history

  28. chore: remove to_owned

    @Al-Kindi-0
    Al-Kindi-0 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4206910 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. GKR: Refactor circuit evaluation (#1345) 

    * `ProjectiveCoordinates`

* Refactor `LayerGatesInputs`

* FractionalSumCircuit2 WIP

* Use `FractionalSumCircuit2` in prover

* SumCheckProverError

* fix number of layers computed

* SumCheckVerifierError

* Remove old `FractionalSumCircuit`

* Remove old `LayerGatesInputs`

* Remove `CircuitGateInputs`

* Document and rename

* docs

* Document `ProjectiveCoordinates`

* sumcheck_round variable ordering

* fix direction of sum-check

* Simplify and clean up (#1347)

* wip: change terminology of circuit eval

* wip: remove left/right num/denom

* chore: remove static

* chore: remove old file and comments

* Document `project_lower_variable`

* chore: minor nits and renaming

---------

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>

* add TODOP

* Use `Wire` terminology

* Remove `CompositionPolynomial::num_variables()`

* fix capacity

* rename `NUM_WIRES_PER_TRACE_ROW` constant

* TODOP

* Introduce `reduce_layer_claim`

* use left/right terminology in GkrCompositionMerge

* adjust TODOP

* fix docs

* docs

* clippy

* clippy

* cleanup prove_before_final_circuit_layers loop

No longer uses an index

* adjust docs

* fmt

* doc nit

* nodes -> wires

* doc nit

* cleanup doc

* document loop

* fmt

---------

Co-authored-by: Al-Kindi-0 <82364884+Al-Kindi-0@users.noreply.github.com>
    @plafer @Al-Kindi-0
    plafer and Al-Kindi-0 authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    09deed7 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Merge branch 'next' into al-gkr-circuit

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8c1842b View commit details
    Browse the repository at this point in the history

  2. remove unused alloc

    @plafer
    plafer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8b7b5c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. docs: minor comment improvements and typo fixes

    @bobbinth
    bobbinth committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    0dca8f2 View commit details
    Browse the repository at this point in the history

  2. refactor: move CompositionPoly from circuit to sumcheck

    @bobbinth
    bobbinth committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    ddd7b50 View commit details
    Browse the repository at this point in the history