Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement error codes for the mtree_verify instructions. #1274

Closed
wants to merge 1 commit into from

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Mar 6, 2024

This PR implements the ability to specify error codes for mtree_verify instruction the same way it is done for assert instructions.

Related issue: #1264

@Fumuran Fumuran linked an issue Mar 6, 2024 that may be closed by this pull request
@Fumuran
Copy link
Contributor Author

Fumuran commented Mar 6, 2024

I noticed that for some reason we still use Felt as an error code for the U32assert2 operation (link), so I probably should create an issue to change it to the u32.

@bobbinth
Copy link
Contributor

bobbinth commented Mar 8, 2024

We should put this on hold until #1277 is merged and then make this work with the new structure.

@bitwalker
Copy link
Contributor

@Overcastan I think you'll find it pretty easy to port this to #1277, if you look at how your implementation of u32clz, etc. was ported to the new structure, it's basically identical, though you'll probably want to reference the Assert non-terminal production in assembly/src/parser/grammar.lalrpop to see how to handle error code immediates specifically. Other than that, most everything else is relatively unchanged from the implementation in this PR.

@plafer
Copy link
Contributor

plafer commented Apr 29, 2024

@Overcastan Are you still working on this?

@bobbinth
Copy link
Contributor

Now that #1277 has been merged, we should refresh this PR.

@Fumuran
Copy link
Contributor Author

Fumuran commented Apr 29, 2024

@plafer Yep, I'll rework it to work with a new version of assembler.

@Fumuran
Copy link
Contributor Author

Fumuran commented May 7, 2024

I decided to create a new PR for this issue, I think it will be easier than resolving conflicts in this one.

@Fumuran Fumuran closed this May 7, 2024
@hackaugusto hackaugusto deleted the andrew-add-err-to-mtree-verify branch May 7, 2024 21:16
@Fumuran Fumuran mentioned this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mtree_verify should also accept err
4 participants