Split up decoder aux column builders into separate files #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
approved these changes
Feb 7, 2024
bobbinth
added a commit
that referenced
this pull request
Feb 8, 2024
bobbinth
added a commit
that referenced
this pull request
Feb 8, 2024
Fumuran
pushed a commit
that referenced
this pull request
Feb 9, 2024
bobbinth
added a commit
that referenced
this pull request
Feb 13, 2024
bobbinth
added a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR spits up column builders for the 3 decoder aux columns into separate files. Also, I've inlined some functions where previously the calling function contained just a single function call.
There should be no actual code changes in this PR.