Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checked variants of u32 MASM instructions #1115

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Remove checked variants of u32 MASM instructions #1115

merged 6 commits into from
Nov 2, 2023

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Oct 20, 2023 •
edited
Loading

This PR removes checked variants of u32 instructions from the assembly. unchecked variants were renamed to get rid of this specification in their names.

Full list of removed and renamed instructions can be found in the corresponding issue #1083

@Fumuran Fumuran requested a review from bobbinth October 20, 2023 20:50
@Fumuran Fumuran linked an issue Oct 20, 2023 that may be closed by this pull request
Remove checked variants of u32 MASM operations #1083
Closed
@Fumuran Fumuran marked this pull request as ready for review October 24, 2023 16:43
@Fumuran Fumuran force-pushed the andrew-remove-checked-ops branch 5 times, most recently from 9d91570 to 5053822 Compare October 27, 2023 17:23
@Fumuran Fumuran mentioned this pull request Oct 29, 2023
Merged
bobbinth
bobbinth requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline.

miden/tests/integration/air/range.rs Outdated Show resolved Hide resolved
stdlib/asm/math/u64.masm Outdated Show resolved Hide resolved
stdlib/asm/math/u64.masm Outdated Show resolved Hide resolved
stdlib/asm/math/u64.masm Show resolved Hide resolved
assembly/src/assembler/instruction/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/assembler/instruction/u32_ops.rs Outdated Show resolved Hide resolved
miden/tests/integration/operations/u32_ops/arithmetic_ops.rs Outdated Show resolved Hide resolved
miden/tests/integration/operations/u32_ops/arithmetic_ops.rs Show resolved Hide resolved
miden/tests/integration/operations/u32_ops/arithmetic_ops.rs Show resolved Hide resolved
miden/tests/integration/operations/u32_ops/arithmetic_ops.rs Show resolved Hide resolved
@Fumuran Fumuran mentioned this pull request Nov 1, 2023
Closed
@Fumuran Fumuran requested a review from bobbinth November 1, 2023 15:54
bobbinth
bobbinth approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I'll merge after reviewing the corresponding PR in Miden base.

@bobbinth bobbinth merged commit 01ee16a into next Nov 2, 2023
15 checks passed
@bobbinth bobbinth deleted the andrew-remove-checked-ops branch November 2, 2023 00:58
This was referenced Nov 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove checked variants of u32 MASM operations
2 participants
@Fumuran @bobbinth