Integration of Falcon DSA into VM #1068
Conversation
feat: Falcon verification masm
assembly/src/ast/parsers/adv_ops.rs
Outdated
| @@ -77,6 +79,16 @@ pub fn parse_adv_inject(op: &Token) -> Result<Node, ParsingError> { | |||
| } | |||
| _ => return Err(ParsingError::extra_param(op)), | |||
| }, | |||
| "push_sign" => match op.num_parts() { | |||
There was a problem hiding this comment.
minor nit: could we change "push_sign" to "push_sig"?
assembly/src/ast/nodes/advice.rs
Outdated
| PUSH_SIGN => Ok(AdviceInjectorNode::PushSignature { | ||
| kind: SignatureKind::RpoFalcon512, | ||
| }), |
There was a problem hiding this comment.
It might be good to write the actual serialization and deserialization code for SignatureKind. The pattern we can use could be something similar to what I used for serializing/deserializing DebugOptions here.
I know we have just a single signature scheme for now, but it would make it more "future-compatible".
There was a problem hiding this comment.
Where should this be placed?
There was a problem hiding this comment.
I'd put it into assembly/src/ast/nodes/serde/signatures.rs or something like that.
| /// Inputs: | ||
| /// Operand stack: [PK, MSG, ...] | ||
| /// Advice stack: [...] | ||
| /// Advice map: {PK: [pk_raw, sk_raw]} | ||
| /// | ||
| /// Outputs: | ||
| /// Operand stack: [PK, MSG, ...] | ||
| /// Advice stack: [NONCE1, NONCE0, h, s2, pi] | ||
| /// Advice map: {PK: [pk_raw, sk_raw]} |
There was a problem hiding this comment.
I think this can be removed from here, and we may want to update some of the description above to reflect that this just generates a signature (and does not interact with the rest of the VM in any way).
| if pk_sk.len() != (PK_LEN + SK_LEN) { | ||
| return Err(ExecutionError::AdviceStackReadFailed(0)); | ||
| } |
There was a problem hiding this comment.
I wonder if we should create a specialized error variant for this. Maybe something like InvalidKeyPair?
| /// Where: | ||
| /// - PK is the digest of an expanded public. | ||
| /// - MSG is the digest of the message to be signed. | ||
| /// - DATA is the needed data for signature verification in the VM. |
There was a problem hiding this comment.
I would probably define DATA in a bit more detail (I believe there are several components to it).
There was a problem hiding this comment.
But they are very specific to Falcon signature. For other DSA they could be group elements etc.
There was a problem hiding this comment.
Ah - makes sense! Let's leave it as is.
|
I have included all the above remarks. I am just not sure about the serialization of |
Al-Kindi-0
force-pushed
the
al-falcon
branch
2 times, most recently
from
a465a17
to
b54c7a1
Compare
|
Superseded by #1094. |
Describe your changes
Addresses #1048
Checklist before requesting a review
nextaccording to naming convention.