-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sync endpoint benchmarks #661
base: santiagopittella-stress-testing-copy
Are you sure you want to change the base?
feat: add sync endpoint benchmarks #661
Conversation
Could you add the errors you're getting? In general the database setup should only apply new migrations. So an existing database won't have any new ones - and we only have a single migration at the moment. It does always log that its doing migrations though so maybe that's just confusing?
|
@Mirko-von-Leipzig this is the error:
|
Hmm. I don't know this code particularly well. My local node's schema version is 13, but I'm unsure why your's would jump to 14. @polydez should be more familiar with this code |
Putting this as draft until block and batch production changes. |
According to the error message in logs, the database structure was changed outside of migrations workflow. If you need to update DB schema, you should update |
Part of #609
I used @TomasArrachea approach to test the
SyncState
endpoint and copied some of his implementation.It adds the tracing used in the node, to ease debugging.
For 10k request, this is the current output:
I also added some methods to the store to initialize an existing DB because
Store::init
always tries to run the migrations and that was causing runtime errores. The node binary usesStore::init
without any errors when using themiden-node start
command; I could not understand why it wasn't failing there. Maybe my new methods (and I'm pretty sure) were not needed. Maybe @Mirko-von-Leipzig @polydez can help me understand why.