Dropped basic wallet account from genesis file #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
approved these changes
Oct 2, 2024
Comment on lines
20
to
22
| pub enum AccountInput { | ||
| BasicWallet(BasicWalletInputs), | ||
| BasicFungibleFaucet(BasicFungibleFaucetInputs), | ||
| } |
There was a problem hiding this comment.
Should we remove the possibility entirely like this? i.e. is there zero value in having a wallet account in the genesis file?
(I think yes, but just checking)
There was a problem hiding this comment.
I was thinking about it and decided that for mainnet we will need to predeploy different accounts and contracts (like DAO for initial funds management), but I don't think that predeployment of simple wallets has any sense for us except testing (but for testing purposes we can deploy wallets in tests).
|
Added @igamigo to reviewers as this will likely affect integration tests on the client. |
igamigo
approved these changes
Oct 2, 2024
Co-authored-by: igamigo <ignacio.amigo@lambdaclass.com>
|
@bobbinth should we merge this PR or you would also like to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #446
In this PR we remove support of basic wallet creation in genesis config.