feat(faucet): embed static website #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to separately bundle this resource, simpliying the deployment process.
The server url is now determined using the webpage url instead of being hardcoded to localhost. This means we no longer have to manually edit it to whatever IP it is being served on.
bobbinth
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies faucet deployment by embedding the website within the binary. This removes the need to separately deploy the website resources.
To facilitate this, this PR also fixes a paper-cut with the javascript callbacks. Previously these were hardcoded to use
localhost:8080as the server address. These would have to be manually edited to the correct URL (which might be a proxy) during deployment. Instead we now usewindow.location.hrefwhich gives the correct url of the current page.Note: I am not a web expert so if anyone has any input on the above that would be welcome.
The static embedding is handled using a build script + additional dependencies, which I dislike but it seems this is the "blessed" way to achieve this using
actix-web.I tested this locally but without a proxy. Though I don't see why this would matter :)