fix: Add aux input to faucet
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
reviewed
Jun 14, 2024
bin/faucet/src/client.rs
Outdated
| @@ -316,6 +317,7 @@ fn build_transaction_arguments( | |||
| &DISTRIBUTE_FUNGIBLE_ASSET_SCRIPT | |||
| .replace("{recipient}", &recipient) | |||
| .replace("{note_type}", &Felt::new(note_type as u64).to_string()) | |||
| .replace("{aux}", &Felt::default().to_string()) | |||
There was a problem hiding this comment.
Might be best to do note.metadata().aux().to_string() here so that it comes from the created note, even if it's hardcoded there as well.
igamigo
approved these changes
Jun 14, 2024
bobbinth
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent change in
miden-basethe faucet stopped working. This PR fixes the note script the faucet uses to send assets.